Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CLI version selection #593

Merged
merged 16 commits into from
Apr 17, 2024
Merged

Refactor CLI version selection #593

merged 16 commits into from
Apr 17, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Apr 15, 2024

Closes #575
Closes #583

Description

The code was maybe a bit cluttered/hard to follow. This attempts to break the functionality up a bit better (moves caching into its own class).

Few functionality changes also:

  • Hoists currently selected binary to top of list when choosing
  • cadence.changeCadenceVersion command was a bit of a misnomer which came from the initial vision of this feature (but has deviated since). This was changed to cadence.changeFlowCliBinary
  • Also fixes a bug where the CLI version selection would break if an invalid flow command was configured at startup.
  • Fixes "bug" when not in workspace folder

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink marked this pull request as ready for review April 15, 2024 21:22
@jribbink jribbink added the improvement Technical work without new features label Apr 15, 2024
@jribbink jribbink merged commit a321cba into master Apr 17, 2024
6 checks passed
@jribbink jribbink deleted the jribbink/cli-version-patch branch April 17, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Technical work without new features
Projects
None yet
2 participants