-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CLI version selection #593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extension/src/dependency-installer/installers/flow-cli-installer.ts
Outdated
Show resolved
Hide resolved
extension/src/dependency-installer/installers/flow-cli-installer.ts
Outdated
Show resolved
Hide resolved
chasefleming
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #575
Closes #583
Description
The code was maybe a bit cluttered/hard to follow. This attempts to break the functionality up a bit better (moves caching into its own class).
Few functionality changes also:
cadence.changeCadenceVersion
command was a bit of a misnomer which came from the initial vision of this feature (but has deviated since). This was changed tocadence.changeFlowCliBinary
For contributor use:
master
branchFiles changed
in the Github PR explorer